chore(deps): upgrade js-yaml from 4.3.2 to 5.4.2 - #2031
Merged
Merged
Conversation
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
🦋 Changeset detectedLatest commit: 7e10e65 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ArtieReus
added
the
greenhouse-pr-build
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The dependency, import, typings, lockfile, and changeset updates are consistent and covered by existing component tests.
Review effort: Balanced
Findings: None
What changed in this PR
Upgrades Greenhouse to js-yaml 5.4.2 and adopts its built-in TypeScript declarations.
Changes:
- Upgraded
js-yamland removed@types/js-yaml. - Updated
YamlViewerto use the nameddumpexport. - Refreshed the lockfile and added a patch changeset.
| File | Description |
|---|---|
apps/greenhouse/package.json |
Updates dependency declarations. |
apps/greenhouse/src/components/admin/common/YamlViewer.tsx |
Uses the v5 named export. |
pnpm-lock.yaml |
Records the updated dependency graph. |
.changeset/upgrade-js-yaml.md |
Documents the patch release. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
github-actions
Bot
added
the
greenhouse-pr-preview
hodanoori
approved these changes
Oct 1, 2026
github-actions
Bot
added
greenhouse-pr-preview
taymoor89
approved these changes
Oct 2, 2026
github-actions
Bot
removed
the
greenhouse-pr-preview
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the
js-yamldependency from version 4.3.2 to 5.4.2 in the greenhouse app. Version 5 includes built-in TypeScript types, eliminating the need for the separate@types/js-yamlpackage.Changes Made
js-yamlfrom 4.3.2 to 5.4.2 inapps/greenhouse/package.json@types/js-yamldependency (no longer needed as v5 includes built-in types)YamlViewer.tsxto use named export (dump) instead of default importpnpm-lock.yamlto reflect the dependency changesRelated Issues
This upgrade is part of the ongoing dependency maintenance. It was separated from PR #1874 (TypeScript 7 upgrade) which is currently blocked by typescript-eslint compatibility.
Screenshots (if applicable)
N/A - No visual changes
Testing Instructions
pnpm icd apps/greenhousepnpm typecheck- Verify TypeScript compilation passespnpm test- Verify all tests pass (104 tests should pass)pnpm lint- Verify linting passespnpm dev- Start the app and verify YAML viewer still works in admin pagesChecklist
PR Manifesto
Review the PR Manifesto for best practises.